OSDN Git Service

[media] dib8000: Fix handling of interleave bigger than 2
authorMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 4 Jul 2014 17:15:27 +0000 (14:15 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Mon, 7 Jul 2014 12:55:04 +0000 (09:55 -0300)
If interleave is bigger than 2, the code will set it to 0, as
dib8000 registers use a log2(). So, change the code to handle
it accordingly.

Acked-By: Patrick Boettcher <pboettcher@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/dvb-frontends/dib8000.c

index 270a58e..78ccbe1 100644 (file)
@@ -2033,9 +2033,8 @@ static u16 dib8000_set_layer(struct dib8000_state *state, u8 layer_index, u16 ma
                        break;
        }
 
-       if ((c->layer[layer_index].interleaving > 0) && ((c->layer[layer_index].interleaving <= 3) || (c->layer[layer_index].interleaving == 4 && c->isdbt_sb_mode == 1)))
-               time_intlv = c->layer[layer_index].interleaving;
-       else
+       time_intlv = fls(c->layer[layer_index].interleaving);
+       if (time_intlv > 3 && !(time_intlv == 4 && c->isdbt_sb_mode == 1))
                time_intlv = 0;
 
        dib8000_write_word(state, 2 + layer_index, (constellation << 10) | ((c->layer[layer_index].segment_count & 0xf) << 6) | (cr << 3) | time_intlv);