OSDN Git Service

scsi: target: sbp: Drop incorrect ASC/ASCQ usage
authorDavid Disseldorp <ddiss@suse.de>
Wed, 28 Jul 2021 11:53:53 +0000 (13:53 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 3 Aug 2021 11:27:43 +0000 (07:27 -0400)
The se_cmd scsi_asc and scsi_ascq members are only used for tracking ALUA
SCSI sense detail between target_core_alua and translate_sense_reason(), so
they're effectively always zero here.

Link: https://lore.kernel.org/r/20210728115353.2396-3-ddiss@suse.de
Cc: Chris Boot <bootc@bootc.net>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/sbp/sbp_target.c

index 4d3ceee..b9f9fb5 100644 (file)
@@ -1389,8 +1389,8 @@ static void sbp_sense_mangle(struct sbp_target_request *req)
                (sense[0] & 0x80) |             /* valid */
                ((sense[2] & 0xe0) >> 1) |      /* mark, eom, ili */
                (sense[2] & 0x0f);              /* sense_key */
-       status[2] = se_cmd->scsi_asc;           /* sense_code */
-       status[3] = se_cmd->scsi_ascq;          /* sense_qualifier */
+       status[2] = 0;                          /* XXX sense_code */
+       status[3] = 0;                          /* XXX sense_qualifier */
 
        /* information */
        status[4] = sense[3];