OSDN Git Service

scsi: mpt3sas: use true,false for bool variables
authorJason Yan <yanaijie@huawei.com>
Tue, 21 Apr 2020 03:41:01 +0000 (11:41 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Apr 2020 04:08:31 +0000 (00:08 -0400)
Fix the following coccicheck warning:

drivers/scsi/mpt3sas/mpt3sas_base.c:416:6-14: WARNING: Assignment of 0/1
to bool variable
drivers/scsi/mpt3sas/mpt3sas_base.c:485:2-10: WARNING: Assignment of 0/1
to bool variable

Link: https://lore.kernel.org/r/20200421034101.28273-1-yanaijie@huawei.com
Acked-by: Suganath Prabu <suganath-prabu.subramani@broadcom.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 663782b..920a3a2 100644 (file)
@@ -413,7 +413,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
 {
        Mpi2SGESimple32_t *sgel, *sgel_next;
        u32  sgl_flags, sge_chain_count = 0;
-       bool is_write = 0;
+       bool is_write = false;
        u16 i = 0;
        void __iomem *buffer_iomem;
        phys_addr_t buffer_iomem_phys;
@@ -482,7 +482,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
 
        if (le32_to_cpu(sgel->FlagsLength) &
                        (MPI2_SGE_FLAGS_HOST_TO_IOC << MPI2_SGE_FLAGS_SHIFT))
-               is_write = 1;
+               is_write = true;
 
        for (i = 0; i < MPT_MIN_PHYS_SEGMENTS + ioc->facts.MaxChainDepth; i++) {