OSDN Git Service

staging: unisys: Remove some extraneous start/stop queue operations
authorNeil Horman <nhorman@redhat.com>
Tue, 21 Jul 2015 13:55:44 +0000 (09:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jul 2015 04:20:25 +0000 (21:20 -0700)
If we put them in the enable and disable paths, we don't need them in
several other places

Signed-off-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index 1231836..338ca8c 100644 (file)
@@ -709,6 +709,7 @@ visornic_enable_with_timeout(struct net_device *netdev, const int timeout)
                return -EIO;
        }
 
+       netif_start_queue(netdev);
        return 0;
 }
 
@@ -730,7 +731,6 @@ visornic_timeout_reset(struct work_struct *work)
        devdata = container_of(work, struct visornic_devdata, timeout_reset);
        netdev = devdata->netdev;
 
-       netif_stop_queue(netdev);
        response = visornic_disable_with_timeout(netdev,
                                                 VISORNIC_INFINITE_RSP_WAIT);
        if (response)
@@ -740,7 +740,6 @@ visornic_timeout_reset(struct work_struct *work)
                                                VISORNIC_INFINITE_RSP_WAIT);
        if (response)
                goto call_serverdown;
-       netif_wake_queue(netdev);
 
        return;
 
@@ -760,11 +759,6 @@ visornic_open(struct net_device *netdev)
 {
        visornic_enable_with_timeout(netdev, VISORNIC_INFINITE_RSP_WAIT);
 
-       /* start the interface's transmit queue, allowing it to accept
-        * packets for transmission
-        */
-       netif_start_queue(netdev);
-
        return 0;
 }
 
@@ -778,7 +772,6 @@ visornic_open(struct net_device *netdev)
 static int
 visornic_close(struct net_device *netdev)
 {
-       netif_stop_queue(netdev);
        visornic_disable_with_timeout(netdev, VISORNIC_INFINITE_RSP_WAIT);
 
        return 0;