OSDN Git Service

ASoC: codecs: lpass-rx-macro: remove useless return
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 16 Apr 2021 19:11:43 +0000 (14:11 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 19 Apr 2021 13:03:32 +0000 (14:03 +0100)
cppcheck warning:

sound/soc/codecs/lpass-rx-macro.c:1626:9: warning: Identical condition
and return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/codecs/lpass-rx-macro.c:1623:6: note: If condition 'ret' is
true, the function will return/exit
 if (ret)
     ^
sound/soc/codecs/lpass-rx-macro.c:1626:9: note: Returning identical
expression 'ret'
 return ret;
        ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20210416191144.27006-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lpass-rx-macro.c

index 14c1665..4f1b569 100644 (file)
@@ -1620,8 +1620,6 @@ static int rx_macro_set_interpolator_rate(struct snd_soc_dai *dai,
                return ret;
 
        ret = rx_macro_set_mix_interpolator_rate(dai, rate_val, sample_rate);
-       if (ret)
-               return ret;
 
        return ret;
 }