OSDN Git Service

drm/mgag200: Remove unecessary NULL check in bo_unref
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:03:22 +0000 (10:03 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:03 +0000 (15:39 +0200)
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/mgag200/mgag200_main.c

index 26868e5..0722d18 100644 (file)
@@ -322,9 +322,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo)
 
        tbo = &((*bo)->bo);
        ttm_bo_unref(&tbo);
-       if (tbo == NULL)
-               *bo = NULL;
-
+       *bo = NULL;
 }
 
 void mgag200_gem_free_object(struct drm_gem_object *obj)