OSDN Git Service

x86/fpu: Remove fpu_allocated()
authorIngo Molnar <mingo@kernel.org>
Fri, 3 Apr 2015 10:34:26 +0000 (12:34 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 19 May 2015 13:47:12 +0000 (15:47 +0200)
It's an unnecessary obfuscation of a very simple allocation pattern.

Reviewed-by: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/fpu-internal.h

index 49db044..21000f0 100644 (file)
@@ -569,14 +569,9 @@ static inline unsigned short get_fpu_mxcsr(struct task_struct *tsk)
        }
 }
 
-static bool fpu_allocated(struct fpu *fpu)
-{
-       return fpu->state != NULL;
-}
-
 static inline int fpu_alloc(struct fpu *fpu)
 {
-       if (fpu_allocated(fpu))
+       if (fpu->state)
                return 0;
        fpu->state = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL);
        if (!fpu->state)