OSDN Git Service

NFS: silence a harmless uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Jul 2018 12:29:29 +0000 (15:29 +0300)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Tue, 31 Jul 2018 16:53:40 +0000 (12:53 -0400)
kstrtoul() can return -ERANGE so Smatch complains that "num" can be
uninitialized.  We check that it's within bounds so it's not a huge
deal.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/super.c

index bdf39fa..ac4b2f0 100644 (file)
@@ -2899,7 +2899,7 @@ static int param_set_portnr(const char *val, const struct kernel_param *kp)
        if (!val)
                return -EINVAL;
        ret = kstrtoul(val, 0, &num);
-       if (ret == -EINVAL || num > NFS_CALLBACK_MAXPORTNR)
+       if (ret || num > NFS_CALLBACK_MAXPORTNR)
                return -EINVAL;
        *((unsigned int *)kp->arg) = num;
        return 0;