OSDN Git Service

Input: ati_remote2 - add missing newlines when printing module parameters
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Wed, 22 Jul 2020 05:24:24 +0000 (22:24 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 22 Jul 2020 05:33:28 +0000 (22:33 -0700)
When I cat some module parameters by sysfs, it displays as follows. It's
better to add a newline for easy reading.

root@syzkaller:~# cat /sys/module/ati_remote2/parameters/mode_mask
0x1froot@syzkaller:~# cat /sys/module/ati_remote2/parameters/channel_mask
0xffffroot@syzkaller:~#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20200720092148.9320-1-wangxiongfeng2@huawei.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/ati_remote2.c

index 305f016..8a36d78 100644 (file)
@@ -68,7 +68,7 @@ static int ati_remote2_get_channel_mask(char *buffer,
 {
        pr_debug("%s()\n", __func__);
 
-       return sprintf(buffer, "0x%04x", *(unsigned int *)kp->arg);
+       return sprintf(buffer, "0x%04x\n", *(unsigned int *)kp->arg);
 }
 
 static int ati_remote2_set_mode_mask(const char *val,
@@ -84,7 +84,7 @@ static int ati_remote2_get_mode_mask(char *buffer,
 {
        pr_debug("%s()\n", __func__);
 
-       return sprintf(buffer, "0x%02x", *(unsigned int *)kp->arg);
+       return sprintf(buffer, "0x%02x\n", *(unsigned int *)kp->arg);
 }
 
 static unsigned int channel_mask = ATI_REMOTE2_MAX_CHANNEL_MASK;