OSDN Git Service

media: ti-vpe: cal: set field always to V4L2_FIELD_NONE
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Mon, 14 Jun 2021 11:23:32 +0000 (13:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 12 Jul 2021 11:17:52 +0000 (13:17 +0200)
cal_camerarx_sd_set_fmt() accepts any value for the format field, but
there should be no reason to have any other value accepted than
V4L2_FIELD_NONE. So set the field always to V4L2_FIELD_NONE.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/ti-vpe/cal-camerarx.c

index a8cca30..f2ea2bd 100644 (file)
@@ -705,10 +705,7 @@ static int cal_camerarx_sd_set_fmt(struct v4l2_subdev *sd,
        if (!fmtinfo)
                fmtinfo = &cal_formats[0];
 
-       /*
-        * Clamp the size, update the code. The field and colorspace are
-        * accepted as-is.
-        */
+       /* Clamp the size, update the code. The colorspace is accepted as-is. */
        bpp = ALIGN(fmtinfo->bpp, 8);
 
        format->format.width = clamp_t(unsigned int, format->format.width,
@@ -718,6 +715,7 @@ static int cal_camerarx_sd_set_fmt(struct v4l2_subdev *sd,
                                        CAL_MIN_HEIGHT_LINES,
                                        CAL_MAX_HEIGHT_LINES);
        format->format.code = fmtinfo->code;
+       format->format.field = V4L2_FIELD_NONE;
 
        /* Store the format and propagate it to the source pad. */
        fmt = cal_camerarx_get_pad_format(phy, sd_state,