OSDN Git Service

drm/bridge: sii902x: fix comparision of u32 with less than zero
authorColin Ian King <colin.king@canonical.com>
Mon, 3 Jun 2019 14:21:02 +0000 (15:21 +0100)
committerAndrzej Hajda <a.hajda@samsung.com>
Fri, 7 Jun 2019 13:01:19 +0000 (15:01 +0200)
The less than check for the variable num_lanes is always going to be
false because the variable is a u32.  Fix this by making num_lanes an
int and also make loop index i an int too.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190603142102.27191-1-colin.king@canonical.com
drivers/gpu/drm/bridge/sii902x.c

index dea784b..84bc2e8 100644 (file)
@@ -729,7 +729,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x,
                .max_i2s_channels = 0,
        };
        u8 lanes[4];
-       u32 num_lanes, i;
+       int num_lanes, i;
 
        if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) {
                dev_dbg(dev, "%s: No \"#sound-dai-cells\", no audio\n",