OSDN Git Service

staging: rtl8723au: Remove unnecessary else following return
authorJanani Ravichandran <janani.rvchndrn@gmail.com>
Thu, 18 Feb 2016 22:56:53 +0000 (17:56 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 23:04:11 +0000 (15:04 -0800)
Remove unnecessary else when there is a return statement in the
corresponding if block.
Coccinelle patch used:

@rule1@
expression e1;
@@

if (e1) { ... return ...; }
-       else{
        ...
-            }

@rule2@
expression e2;
statement s1;
@@

if(e2) { ... return ...; }
-       else
s1

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/hal/hal_com.c

index 530db57..9d7b11b 100644 (file)
@@ -328,7 +328,7 @@ int c2h_evt_read23a(struct rtw_adapter *adapter, u8 *buf)
 
        if (trigger == C2H_EVT_HOST_CLOSE)
                goto exit;      /* Not ready */
-       else if (trigger != C2H_EVT_FW_CLOSE)
+       if (trigger != C2H_EVT_FW_CLOSE)
                goto clear_evt; /* Not a valid value */
 
        c2h_evt = (struct c2h_evt_hdr *)buf;