OSDN Git Service

USB: input: aiptek.c: fix up dev_err() usage
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 00:56:56 +0000 (20:56 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 00:56:56 +0000 (20:56 -0400)
We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Jesper Juhl <jj@chaosbits.net>
CC: JJ Ding <dgdunix@gmail.com>
CC: Edwin van Vliet <edwin@cheatah.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/tablet/aiptek.c

index b8d43eb..dc16bfd 100644 (file)
@@ -811,7 +811,7 @@ static void aiptek_irq(struct urb *urb)
 exit:
        retval = usb_submit_urb(urb, GFP_ATOMIC);
        if (retval != 0) {
-               dev_err(&aiptek->usbdev->dev,
+               dev_err(&inputdev->dev,
                        "%s - usb_submit_urb failed with result %d\n",
                        __func__, retval);
        }