OSDN Git Service

drm/mediatek: Eliminate the magic number in array size
authorBernard Zhao <bernard@vivo.com>
Wed, 6 May 2020 12:42:55 +0000 (05:42 -0700)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Wed, 20 May 2020 16:10:08 +0000 (00:10 +0800)
Eiminate the magic number in array size, there macro defines in
hdmi.h.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_hdmi.c

index 43e9876..7bc086e 100644 (file)
@@ -978,7 +978,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi,
                                        struct drm_display_mode *mode)
 {
        struct hdmi_avi_infoframe frame;
-       u8 buffer[17];
+       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AVI_INFOFRAME_SIZE];
        ssize_t err;
 
        err = drm_hdmi_avi_infoframe_from_display_mode(&frame,
@@ -1004,7 +1004,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,
                                        const char *product)
 {
        struct hdmi_spd_infoframe frame;
-       u8 buffer[29];
+       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_SPD_INFOFRAME_SIZE];
        ssize_t err;
 
        err = hdmi_spd_infoframe_init(&frame, vendor, product);
@@ -1027,7 +1027,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct mtk_hdmi *hdmi,
 static int mtk_hdmi_setup_audio_infoframe(struct mtk_hdmi *hdmi)
 {
        struct hdmi_audio_infoframe frame;
-       u8 buffer[14];
+       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AUDIO_INFOFRAME_SIZE];
        ssize_t err;
 
        err = hdmi_audio_infoframe_init(&frame);