OSDN Git Service

pinctrl: qcom: enable generic pinconf
authorStanimir Varbanov <svarbanov@mm-sol.com>
Wed, 4 Mar 2015 10:41:56 +0000 (12:41 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 9 Mar 2015 17:11:01 +0000 (18:11 +0100)
This makes the pinctrl driver to use the generic pinconf
interface. Mainly it gives us a way to use debugfs to dump
group configurations.

Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-msm.c

index a535f9c..d36e511 100644 (file)
@@ -197,7 +197,6 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
                *mask = 1;
                break;
        default:
-               dev_err(pctrl->dev, "Invalid config param %04x\n", param);
                return -ENOTSUPP;
        }
 
@@ -262,9 +261,7 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev,
                arg = !!(val & BIT(g->in_bit));
                break;
        default:
-               dev_err(pctrl->dev, "Unsupported config parameter: %x\n",
-                       param);
-               return -EINVAL;
+               return -ENOTSUPP;
        }
 
        *config = pinconf_to_config_packed(param, arg);
@@ -357,6 +354,7 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
 }
 
 static const struct pinconf_ops msm_pinconf_ops = {
+       .is_generic             = true,
        .pin_config_group_get   = msm_config_group_get,
        .pin_config_group_set   = msm_config_group_set,
 };