OSDN Git Service

drm/arm: remove _unlocked suffix in drm_gem_object_put_unlocked
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 15 May 2020 09:50:55 +0000 (10:50 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 19 May 2020 21:31:31 +0000 (22:31 +0100)
Spelling out _unlocked for each and every driver is a annoying.
Especially if we consider how many drivers, do not know (or need to)
about the horror stories involving struct_mutex.

Just drop the suffix. It makes the API cleaner.

Done via the following script:

__from=drm_gem_object_put_unlocked
__to=drm_gem_object_put
for __file in $(git grep --name-only $__from); do
  sed -i  "s/$__from/$__to/g" $__file;
done

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-16-emil.l.velikov@gmail.com
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
drivers/gpu/drm/arm/malidp_drv.c

index 1b01a62..170f9dc 100644 (file)
@@ -19,7 +19,7 @@ static void komeda_fb_destroy(struct drm_framebuffer *fb)
        u32 i;
 
        for (i = 0; i < fb->format->num_planes; i++)
-               drm_gem_object_put_unlocked(fb->obj[i]);
+               drm_gem_object_put(fb->obj[i]);
 
        drm_framebuffer_cleanup(fb);
        kfree(kfb);
@@ -103,7 +103,7 @@ komeda_fb_afbc_size_check(struct komeda_fb *kfb, struct drm_file *file,
        return 0;
 
 check_failed:
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
        return -EINVAL;
 }
 
@@ -199,7 +199,7 @@ komeda_fb_create(struct drm_device *dev, struct drm_file *file,
 
 err_cleanup:
        for (i = 0; i < kfb->base.format->num_planes; i++)
-               drm_gem_object_put_unlocked(kfb->base.obj[i]);
+               drm_gem_object_put(kfb->base.obj[i]);
 
        kfree(kfb);
        return ERR_PTR(ret);
index def8c9f..c2507b7 100644 (file)
@@ -349,11 +349,11 @@ malidp_verify_afbc_framebuffer_size(struct drm_device *dev,
        if (objs->size < afbc_size) {
                DRM_DEBUG_KMS("buffer size (%zu) too small for AFBC buffer size = %u\n",
                              objs->size, afbc_size);
-               drm_gem_object_put_unlocked(objs);
+               drm_gem_object_put(objs);
                return false;
        }
 
-       drm_gem_object_put_unlocked(objs);
+       drm_gem_object_put(objs);
 
        return true;
 }