OSDN Git Service

net/ibmvnic: Remove tests of member address
authorWen Yang <wen.yang99@zte.com.cn>
Tue, 11 Dec 2018 04:20:46 +0000 (12:20 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Dec 2018 21:36:38 +0000 (13:36 -0800)
The driver was checking for non-NULL address.
- adapter->napi[i]

This is pointless as these will be always non-NULL, since the
'dapter->napi' is allocated in init_napi().
It is safe to get rid of useless checks for addresses to fix the
coccinelle warning:
>>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
Since such statements always return true, they are redundant.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Michael Ellerman <mpe@ellerman.id.au>
CC: Thomas Falcon <tlfalcon@linux.ibm.com>
CC: John Allen <jallen@linux.ibm.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: linuxppc-dev@lists.ozlabs.org
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index ed50b8d..14d0098 100644 (file)
@@ -773,11 +773,8 @@ static void release_napi(struct ibmvnic_adapter *adapter)
                return;
 
        for (i = 0; i < adapter->num_active_rx_napi; i++) {
-               if (&adapter->napi[i]) {
-                       netdev_dbg(adapter->netdev,
-                                  "Releasing napi[%d]\n", i);
-                       netif_napi_del(&adapter->napi[i]);
-               }
+               netdev_dbg(adapter->netdev, "Releasing napi[%d]\n", i);
+               netif_napi_del(&adapter->napi[i]);
        }
 
        kfree(adapter->napi);