OSDN Git Service

scsi: ipr: Directly return instead of using local ret variable
authorHaowen Bai <baihaowen@meizu.com>
Mon, 28 Mar 2022 02:05:03 +0000 (10:05 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 Apr 2022 03:29:40 +0000 (23:29 -0400)
Fixes coccinelle warning:

./drivers/scsi/ipr.c:10095:13-15: Unneeded variable: "rc". Return "IRQ_HANDLED" on line 10104

Link: https://lore.kernel.org/r/1648433103-24308-1-git-send-email-baihaowen@meizu.com
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ipr.c

index 104bee9..353cf47 100644 (file)
@@ -10092,7 +10092,6 @@ static irqreturn_t ipr_test_intr(int irq, void *devp)
 {
        struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)devp;
        unsigned long lock_flags = 0;
-       irqreturn_t rc = IRQ_HANDLED;
 
        dev_info(&ioa_cfg->pdev->dev, "Received IRQ : %d\n", irq);
        spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
@@ -10101,7 +10100,7 @@ static irqreturn_t ipr_test_intr(int irq, void *devp)
        wake_up(&ioa_cfg->msi_wait_q);
 
        spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
-       return rc;
+       return IRQ_HANDLED;
 }
 
 /**