OSDN Git Service

platform/x86: think-lmi: Use min_t() for comparison and assignment
authorDeepak R Varma <drv@mailo.com>
Fri, 27 Jan 2023 20:05:56 +0000 (01:35 +0530)
committerHans de Goede <hdegoede@redhat.com>
Fri, 3 Feb 2023 09:01:50 +0000 (10:01 +0100)
Simplify code by using min_t helper macro for logical evaluation
and value assignment. Use the _t variant of min macro since the
variable types are not same.
This issue is identified by coccicheck using the minmax.cocci file.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/Y9QupEMPFoZpWIiM@ubun2204.myguest.virtualbox.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/think-lmi.c

index a01a927..caa8625 100644 (file)
@@ -317,8 +317,8 @@ static int tlmi_get_pwd_settings(struct tlmi_pwdcfg *pwdcfg)
                return -EIO;
        }
 
-       copy_size = obj->buffer.length < sizeof(struct tlmi_pwdcfg) ?
-               obj->buffer.length : sizeof(struct tlmi_pwdcfg);
+       copy_size = min_t(size_t, obj->buffer.length, sizeof(struct tlmi_pwdcfg));
+
        memcpy(pwdcfg, obj->buffer.pointer, copy_size);
        kfree(obj);