OSDN Git Service

scsi: lpfc: Fix lpfc_sli4_read_config return value check
authorJames Smart <jsmart2021@gmail.com>
Tue, 23 Oct 2018 20:41:02 +0000 (13:41 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Nov 2018 01:42:50 +0000 (20:42 -0500)
An error is an error - but not to the existing return value check.

Revise check to handle any failure, not just EIO.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c

index df0ec52..7f63d32 100644 (file)
@@ -4896,11 +4896,11 @@ lpfc_sli4_async_sli_evt(struct lpfc_hba *phba, struct lpfc_acqe_sli *acqe_sli)
 
                /* Issue READ_CONFIG mbox command to refresh supported speeds */
                rc = lpfc_sli4_read_config(phba);
-               if (rc == -EIO) {
+               if (rc) {
                        phba->lmt = 0;
                        lpfc_printf_log(phba, KERN_ERR, LOG_SLI,
                                        "3194 Unable to retrieve supported "
-                                       "speeds\n");
+                                       "speeds, rc = 0x%x\n", rc);
                }
                vports = lpfc_create_vport_work_array(phba);
                if (vports != NULL) {