OSDN Git Service

perf top: Use set_term_quiet() instead of open coded equivalent
authorJiri Olsa <jolsa@kernel.org>
Fri, 15 Aug 2014 19:24:45 +0000 (16:24 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sun, 24 Aug 2014 11:11:18 +0000 (08:11 -0300)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jean Pihet <jean.pihet@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-h7n9te70flmaqfnj6l06ay6r@git.kernel.org
[ Yanked this out of a patch containing this and some other change ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c

index a77ff6c..9848e27 100644 (file)
@@ -433,18 +433,13 @@ static bool perf_top__handle_keypress(struct perf_top *top, int c)
 
        if (!perf_top__key_mapped(top, c)) {
                struct pollfd stdin_poll = { .fd = 0, .events = POLLIN };
-               struct termios tc, save;
+               struct termios save;
 
                perf_top__print_mapped_keys(top);
                fprintf(stdout, "\nEnter selection, or unmapped key to continue: ");
                fflush(stdout);
 
-               tcgetattr(0, &save);
-               tc = save;
-               tc.c_lflag &= ~(ICANON | ECHO);
-               tc.c_cc[VMIN] = 0;
-               tc.c_cc[VTIME] = 0;
-               tcsetattr(0, TCSANOW, &tc);
+               set_term_quiet_input(&save);
 
                poll(&stdin_poll, 1, -1);
                c = getc(stdin);