CultureInfoを指定できるメソッドでCultureInfoを常に明示する (CA1304)

diff --git a/OpenTween/Connection/HttpConnection.cs b/OpenTween/Connection/HttpConnection.cs
index d5fe2d4..7227f2d 100644 (file)
--- a/OpenTween/Connection/HttpConnection.cs
+++ b/OpenTween/Connection/HttpConnection.cs
@@ -192,7 +192,7 @@ namespace OpenTween
                             byte[] crlfByte = Encoding.UTF8.GetBytes("\r\n");
                             //コンテンツタイプの指定
                             string mime = "";
-                            switch (kvp.Value.Extension.ToLower())
+                            switch (kvp.Value.Extension.ToLowerInvariant())
                             {
                                 case ".jpg":
                                 case ".jpeg":

diff --git a/OpenTween/Connection/TwitterPhoto.cs b/OpenTween/Connection/TwitterPhoto.cs
index 805bcf2..0b3c4a4 100644 (file)
--- a/OpenTween/Connection/TwitterPhoto.cs
+++ b/OpenTween/Connection/TwitterPhoto.cs
@@ -62,7 +62,7 @@ namespace OpenTween.Connection
 
         public bool CheckFileExtension(string fileExtension)
         {
-            return this.pictureExt.Contains(fileExtension.ToLower());
+            return this.pictureExt.Contains(fileExtension.ToLowerInvariant());
         }
 
         public bool CheckFileSize(string fileExtension, long fileSize)

diff --git a/OpenTween/Connection/imgly.cs b/OpenTween/Connection/imgly.cs
index 162523b..f7c420a 100644 (file)
--- a/OpenTween/Connection/imgly.cs
+++ b/OpenTween/Connection/imgly.cs
@@ -71,7 +71,7 @@ namespace OpenTween.Connection
 
         public bool CheckFileExtension(string fileExtension)
         {
-            return this.pictureExt.Contains(fileExtension.ToLower());
+            return this.pictureExt.Contains(fileExtension.ToLowerInvariant());
         }
 
         public bool CheckFileSize(string fileExtension, long fileSize)

diff --git a/OpenTween/Connection/yfrog.cs b/OpenTween/Connection/yfrog.cs
index 10f060a..bdf9fc9 100644 (file)
--- a/OpenTween/Connection/yfrog.cs
+++ b/OpenTween/Connection/yfrog.cs
@@ -71,7 +71,7 @@ namespace OpenTween.Connection
 
         public bool CheckFileExtension(string fileExtension)
         {
-            return this.pictureExt.Contains(fileExtension.ToLower());
+            return this.pictureExt.Contains(fileExtension.ToLowerInvariant());
         }
 
         public bool CheckFileSize(string fileExtension, long fileSize)

diff --git a/OpenTween/EventViewerDialog.cs b/OpenTween/EventViewerDialog.cs
index de46935..de44f5b 100644 (file)
--- a/OpenTween/EventViewerDialog.cs
+++ b/OpenTween/EventViewerDialog.cs
@@ -35,6 +35,7 @@ using System.Text;
 using System.Windows.Forms;
 using System.Text.RegularExpressions;
 using System.IO;
+using System.Globalization;
 
 namespace OpenTween
 {
@@ -77,7 +78,7 @@ namespace OpenTween
 
         private ListViewItem CreateListViewItem(Twitter.FormattedEvent source)
         {
-            string[] s = { source.CreatedAt.ToString(), source.Event.ToUpper(), source.Username, source.Target };
+            string[] s = { source.CreatedAt.ToString(), source.Event.ToUpper(CultureInfo.CurrentCulture), source.Username, source.Target };
             return new ListViewItem(s);
         }
 

diff --git a/OpenTween/Growl.cs b/OpenTween/Growl.cs
index c06e32b..5be2983 100644 (file)
--- a/OpenTween/Growl.cs
+++ b/OpenTween/Growl.cs
@@ -35,6 +35,7 @@ using System.Drawing.Imaging;
 using System.Windows.Forms;
 using System.ComponentModel;
 using System.Collections;
+using System.Globalization;
 
 namespace OpenTween
 {
@@ -157,21 +158,21 @@ namespace OpenTween
                 Type _t = _connector.GetType("Growl.Connector.NotificationType");
 
                 _growlNTreply = _t.InvokeMember(null,
-                    BindingFlags.CreateInstance, null, null, new object[] { "REPLY", "Reply" });
+                    BindingFlags.CreateInstance, null, null, new object[] { "REPLY", "Reply" }, CultureInfo.InvariantCulture);
 
                 _growlNTdm = _t.InvokeMember(null,
-                    BindingFlags.CreateInstance, null, null, new object[] { "DIRECT_MESSAGE", "DirectMessage" });
+                    BindingFlags.CreateInstance, null, null, new object[] { "DIRECT_MESSAGE", "DirectMessage" }, CultureInfo.InvariantCulture);
 
                 _growlNTnew = _t.InvokeMember(null,
-                    BindingFlags.CreateInstance, null, null, new object[] { "NOTIFY", "新着通知" });
+                    BindingFlags.CreateInstance, null, null, new object[] { "NOTIFY", "新着通知" }, CultureInfo.InvariantCulture);
 
                 _growlNTusevent = _t.InvokeMember(null,
-                    BindingFlags.CreateInstance, null, null, new object[] { "USERSTREAM_EVENT", "UserStream Event" });
+                    BindingFlags.CreateInstance, null, null, new object[] { "USERSTREAM_EVENT", "UserStream Event" }, CultureInfo.InvariantCulture);
 
                 object encryptType =
                         _connector.GetType("Growl.Connector.Cryptography+SymmetricAlgorithmType").InvokeMember(
-                            "PlainText", BindingFlags.GetField, null, null, null);
-                _targetConnector.GetType().InvokeMember("EncryptionAlgorithm", BindingFlags.SetProperty, null, _targetConnector, new object[] { encryptType });
+                            "PlainText", BindingFlags.GetField, null, null, null, CultureInfo.InvariantCulture);
+                _targetConnector.GetType().InvokeMember("EncryptionAlgorithm", BindingFlags.SetProperty, null, _targetConnector, new object[] { encryptType }, CultureInfo.InvariantCulture);
 
                 _growlApp = _connector.CreateInstance(
                     "Growl.Connector.Application", false, BindingFlags.Default, null, new object[] { _appName }, null, null);
@@ -292,7 +293,8 @@ namespace OpenTween
                                              BindingFlags.Public | BindingFlags.Static | BindingFlags.InvokeMethod,
                                              null,
                                              null,
-                                             new object[] { icon });
+                                             new object[] { icon },
+                                             CultureInfo.InvariantCulture);
                 }
                 else
                 {
@@ -300,11 +302,12 @@ namespace OpenTween
                                              BindingFlags.Public | BindingFlags.Static | BindingFlags.InvokeMethod,
                                              null,
                                              null,
-                                             new object[] { url });
+                                             new object[] { url },
+                                             CultureInfo.InvariantCulture);
                 }
                 object priority =
                         _connector.GetType("Growl.Connector.Priority").InvokeMember(
-                            "Normal", BindingFlags.GetField, null, null, null);
+                            "Normal", BindingFlags.GetField, null, null, null, CultureInfo.InvariantCulture);
                 n = _connector.GetType("Growl.Connector.Notification").InvokeMember(
                         "Notification",
                         BindingFlags.CreateInstance,
@@ -318,7 +321,8 @@ namespace OpenTween
                                       res,
                                       false,
                                       priority,
-                                      "aaa"});
+                                      "aaa"},
+                        CultureInfo.InvariantCulture);
             }
             else
             {
@@ -331,13 +335,15 @@ namespace OpenTween
                                       notificationName,
                                       id,
                                       title,
-                                      text});
+                                      text},
+                        CultureInfo.InvariantCulture);
             }
             //_targetConnector.GetType.InvokeMember("Notify", BindingFlags.InvokeMethod, null, _targetConnector, new object[] {n});
             object cc = _connector.GetType("Growl.Connector.CallbackContext").InvokeMember(
                 null, BindingFlags.CreateInstance, null, _connector,
-                new object[] { "some fake information", notificationName });
-            _targetConnector.GetType().InvokeMember("Notify", BindingFlags.InvokeMethod, null, _targetConnector, new object[] { n, cc });
+                new object[] { "some fake information", notificationName },
+                CultureInfo.InvariantCulture);
+            _targetConnector.GetType().InvokeMember("Notify", BindingFlags.InvokeMethod, null, _targetConnector, new object[] { n, cc }, CultureInfo.InvariantCulture);
         }
 
         private void GrowlCallbackHandler(object response, object callbackData, object state)

diff --git a/OpenTween/HashtagManage.cs b/OpenTween/HashtagManage.cs
index da1c67f..8ba601c 100644 (file)
--- a/OpenTween/HashtagManage.cs
+++ b/OpenTween/HashtagManage.cs
@@ -29,6 +29,7 @@ using System.Collections.Generic;
 using System.ComponentModel;
 using System.Data;
 using System.Drawing;
+using System.Globalization;
 using System.Linq;
 using System.Text;
 using System.Windows.Forms;
@@ -133,7 +134,7 @@ namespace OpenTween
                     idx += 1;
                     continue;
                 }
-                if (string.Compare(src, value, true) == 0)
+                if (string.Compare(src, value, true, CultureInfo.InvariantCulture) == 0)
                 {
                     return idx;
                 }

diff --git a/OpenTween/MyCommon.cs b/OpenTween/MyCommon.cs
index 73d3417..ca490a6 100644 (file)
--- a/OpenTween/MyCommon.cs
+++ b/OpenTween/MyCommon.cs
@@ -491,7 +491,7 @@ namespace OpenTween
                     }
                     else
                     {
-                        sb.Append("%" + Convert.ToInt16(c).ToString("X2").ToUpper());
+                        sb.Append("%" + Convert.ToInt16(c).ToString("X2").ToUpperInvariant());
                     }
                 }
                 else

diff --git a/OpenTween/OpenTween.ruleset b/OpenTween/OpenTween.ruleset
index 7a61a40..5a48413 100644 (file)
--- a/OpenTween/OpenTween.ruleset
+++ b/OpenTween/OpenTween.ruleset
@@ -28,6 +28,7 @@
     <Rule Id="CA1064" Action="Warning" />
     <Rule Id="CA1065" Action="Warning" />
     <Rule Id="CA1301" Action="Warning" />
+    <Rule Id="CA1304" Action="Warning" />
     <Rule Id="CA1400" Action="Warning" />
     <Rule Id="CA1401" Action="Warning" />
     <Rule Id="CA1403" Action="Warning" />

diff --git a/OpenTween/Tween.cs b/OpenTween/Tween.cs
index cf05528..4388e04 100644 (file)
--- a/OpenTween/Tween.cs
+++ b/OpenTween/Tween.cs
@@ -34,6 +34,7 @@ using System.Collections.Generic;
 using System.ComponentModel;
 using System.Diagnostics;
 using System.Drawing;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Media;
@@ -1179,7 +1180,7 @@ namespace OpenTween
 
             foreach (var ua in this._cfgCommon.UserAccounts)
             {
-                if (ua.UserId == 0 && ua.Username.ToLower() == tw.Username.ToLower())
+                if (ua.UserId == 0 && ua.Username.ToLowerInvariant() == tw.Username.ToLowerInvariant())
                 {
                     ua.UserId = tw.UserId;
                     break;
@@ -2073,10 +2074,10 @@ namespace OpenTween
             else if (TargetPost.IsReply)
                 //自分宛返信
                 cl = _clAtSelf;
-            else if (BasePost.ReplyToList.Contains(TargetPost.ScreenName.ToLower()))
+            else if (BasePost.ReplyToList.Contains(TargetPost.ScreenName.ToLowerInvariant()))
                 //返信先
                 cl = _clAtFromTarget;
-            else if (TargetPost.ReplyToList.Contains(BasePost.ScreenName.ToLower()))
+            else if (TargetPost.ReplyToList.Contains(BasePost.ScreenName.ToLowerInvariant()))
                 //その人への返信
                 cl = _clAtTarget;
             else if (TargetPost.ScreenName.Equals(BasePost.ScreenName, StringComparison.OrdinalIgnoreCase))
@@ -7422,10 +7423,10 @@ namespace OpenTween
                     post.RetweetedBy == _anchorPost.ScreenName ||
                     post.ScreenName == _anchorPost.RetweetedBy ||
                     (!string.IsNullOrEmpty(post.RetweetedBy) && post.RetweetedBy == _anchorPost.RetweetedBy) ||
-                    _anchorPost.ReplyToList.Contains(post.ScreenName.ToLower()) ||
-                    _anchorPost.ReplyToList.Contains(post.RetweetedBy.ToLower()) ||
-                    post.ReplyToList.Contains(_anchorPost.ScreenName.ToLower()) ||
-                    post.ReplyToList.Contains(_anchorPost.RetweetedBy.ToLower()))
+                    _anchorPost.ReplyToList.Contains(post.ScreenName.ToLowerInvariant()) ||
+                    _anchorPost.ReplyToList.Contains(post.RetweetedBy.ToLowerInvariant()) ||
+                    post.ReplyToList.Contains(_anchorPost.ScreenName.ToLowerInvariant()) ||
+                    post.ReplyToList.Contains(_anchorPost.RetweetedBy.ToLowerInvariant()))
                 {
                     SelectListItem(_curList, idx);
                     _curList.EnsureVisible(idx);
@@ -10642,7 +10643,7 @@ namespace OpenTween
             bool fAllFlag = false;
             foreach (Match mu in ma)
             {
-                if (mu.Result("${ScreenName}").ToLower() != tw.Username.ToLower())
+                if (mu.Result("${ScreenName}").ToLowerInvariant() != tw.Username.ToLowerInvariant())
                 {
                     fAllFlag = true;
                     break;
@@ -11612,7 +11613,7 @@ namespace OpenTween
             if (this.tw.Configuration.NonUsernamePaths == null || this.tw.Configuration.NonUsernamePaths.Length == 0)
                 return !Regex.Match(name, @"^(about|jobs|tos|privacy|who_to_follow|download|messages)$", RegexOptions.IgnoreCase).Success;
             else
-                return !this.tw.Configuration.NonUsernamePaths.Contains(name.ToLower());
+                return !this.tw.Configuration.NonUsernamePaths.Contains(name.ToLowerInvariant());
         }
 
         private string GetUserId()
@@ -12984,7 +12985,7 @@ namespace OpenTween
                     this.PurgeListViewItemCache();
                     ((DetailsListView)_curTab.Tag).Update();
                 }
-                if (ev.Event == "unfavorite" && ev.Username.ToLower().Equals(tw.Username.ToLower()))
+                if (ev.Event == "unfavorite" && ev.Username.ToLowerInvariant().Equals(tw.Username.ToLowerInvariant()))
                 {
                     RemovePostFromFavTab(new long[] {ev.Id});
                 }
@@ -13011,7 +13012,7 @@ namespace OpenTween
                 }
                 title.Append(Application.ProductName);
                 title.Append(" [");
-                title.Append(ev.Event.ToUpper());
+                title.Append(ev.Event.ToUpper(CultureInfo.CurrentCulture));
                 title.Append("] by ");
                 if (!string.IsNullOrEmpty(ev.Username))
                 {

diff --git a/OpenTween/Twitter.cs b/OpenTween/Twitter.cs
index 2364f2e..bca0801 100644 (file)
--- a/OpenTween/Twitter.cs
+++ b/OpenTween/Twitter.cs
@@ -204,7 +204,7 @@ namespace OpenTween
 
             this.CheckStatusCode(res, content);
 
-            _uname = username.ToLower();
+            _uname = username.ToLowerInvariant();
             if (SettingCommon.Instance.UserstreamStartup) this.ReconnectUserStream();
         }
 
@@ -243,7 +243,7 @@ namespace OpenTween
 
             this.CheckStatusCode(res, null);
 
-            _uname = Username.ToLower();
+            _uname = Username.ToLowerInvariant();
             if (SettingCommon.Instance.UserstreamStartup) this.ReconnectUserStream();
         }
 
@@ -292,7 +292,7 @@ namespace OpenTween
             }
             this.ResetApiStatus();
             twCon.Initialize(token, tokenSecret, username, userId);
-            _uname = username.ToLower();
+            _uname = username.ToLowerInvariant();
             if (SettingCommon.Instance.UserstreamStartup) this.ReconnectUserStream();
         }
 
@@ -1577,7 +1577,7 @@ namespace OpenTween
                 //Retweetした人
                 post.RetweetedBy = status.User.ScreenName;
                 post.RetweetedByUserId = status.User.Id;
-                post.IsMe = post.RetweetedBy.ToLower().Equals(_uname);
+                post.IsMe = post.RetweetedBy.ToLowerInvariant().Equals(_uname);
             }
             else
             {
@@ -1614,7 +1614,7 @@ namespace OpenTween
                 post.Nickname = user.Name.Trim();
                 post.ImageUrl = user.ProfileImageUrlHttps;
                 post.IsProtect = user.Protected;
-                post.IsMe = post.ScreenName.ToLower().Equals(_uname);
+                post.IsMe = post.ScreenName.ToLowerInvariant().Equals(_uname);
             }
             //HTMLに整形
             string textFromApi = post.TextFromApi;
@@ -2696,7 +2696,7 @@ namespace OpenTween
                 {
                     foreach (var ent in entities.UserMentions)
                     {
-                        var screenName = ent.ScreenName.ToLower();
+                        var screenName = ent.ScreenName.ToLowerInvariant();
                         if (!AtList.Contains(screenName))
                             AtList.Add(screenName);
                     }
@@ -3285,7 +3285,7 @@ namespace OpenTween
             evt.CreatedAt = MyCommon.DateTimeParse(eventData.CreatedAt);
             evt.Event = eventData.Event;
             evt.Username = eventData.Source.ScreenName;
-            evt.IsMe = evt.Username.ToLower().Equals(this.Username.ToLower());
+            evt.IsMe = evt.Username.ToLowerInvariant().Equals(this.Username.ToLowerInvariant());
 
             MyCommon.EVENTTYPE eventType;
             eventTable.TryGetValue(eventData.Event, out eventType);
@@ -3301,7 +3301,7 @@ namespace OpenTween
                 case "user_suspend":
                     return;
                 case "follow":
-                    if (eventData.Target.ScreenName.ToLower().Equals(_uname))
+                    if (eventData.Target.ScreenName.ToLowerInvariant().Equals(_uname))
                     {
                         if (!this.followerId.Contains(eventData.Source.Id)) this.followerId.Add(eventData.Source.Id);
                     }

diff --git a/OpenTween/UserInfoDialog.cs b/OpenTween/UserInfoDialog.cs
index 732c433..01f1b10 100644 (file)
--- a/OpenTween/UserInfoDialog.cs
+++ b/OpenTween/UserInfoDialog.cs
@@ -668,7 +668,7 @@ namespace OpenTween
 
         private bool IsValidExtension(string ext)
         {
-            ext = ext.ToLower();
+            ext = ext.ToLowerInvariant();
 
             return ext.Equals(".jpg", StringComparison.Ordinal) ||
                 ext.Equals(".jpeg", StringComparison.Ordinal) ||