OSDN Git Service

[ProfileData] Pass Twine by const reference instead of by value.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Wed, 6 Jan 2021 14:04:37 +0000 (14:04 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Wed, 6 Jan 2021 14:22:03 +0000 (14:22 +0000)
Its only used by DiagnosticInfoSampleProfile which takes a const reference anyhow.

llvm/include/llvm/ProfileData/SampleProfReader.h

index 35e71f3..92fe825 100644 (file)
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringMap.h"
 #include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/Twine.h"
 #include "llvm/IR/DiagnosticInfo.h"
 #include "llvm/IR/Function.h"
 #include "llvm/IR/LLVMContext.h"
 namespace llvm {
 
 class raw_ostream;
+class Twine;
 
 namespace sampleprof {
 
@@ -408,7 +408,7 @@ public:
   StringMap<FunctionSamples> &getProfiles() { return Profiles; }
 
   /// Report a parse error message.
-  void reportError(int64_t LineNumber, Twine Msg) const {
+  void reportError(int64_t LineNumber, const Twine &Msg) const {
     Ctx.diagnose(DiagnosticInfoSampleProfile(Buffer->getBufferIdentifier(),
                                              LineNumber, Msg));
   }