OSDN Git Service

igc: Fix NFC rules with multicast addresses
authorAndre Guedes <andre.guedes@intel.com>
Fri, 24 Apr 2020 20:16:16 +0000 (13:16 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sat, 23 May 2020 01:21:51 +0000 (18:21 -0700)
Multicast MAC addresses are valid address for NFC rules but
igc_add_mac_filter() is currently rejecting them. In fact, the I225
controller doesn't impose any constraint on the address value so this
patch gets rid of the address validation check in MAC filter APIs.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igc/igc_main.c

index f48d612..acb8dfd 100644 (file)
@@ -2249,9 +2249,6 @@ int igc_add_mac_filter(struct igc_adapter *adapter,
        struct net_device *dev = adapter->netdev;
        int index;
 
-       if (!is_valid_ether_addr(addr))
-               return -EINVAL;
-
        index = igc_find_mac_filter(adapter, type, addr);
        if (index >= 0)
                goto update_filter;
@@ -2283,9 +2280,6 @@ int igc_del_mac_filter(struct igc_adapter *adapter,
        struct net_device *dev = adapter->netdev;
        int index;
 
-       if (!is_valid_ether_addr(addr))
-               return -EINVAL;
-
        index = igc_find_mac_filter(adapter, type, addr);
        if (index < 0)
                return -ENOENT;