OSDN Git Service

phy: phy-ti-pipe3: Remove unncessary site specific OOM messages
authorPeter Griffin <peter.griffin@linaro.org>
Fri, 15 Aug 2014 12:40:11 +0000 (13:40 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 24 Sep 2014 09:48:32 +0000 (15:18 +0530)
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().

Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-ti-pipe3.c

index b964aa9..9280ef8 100644 (file)
@@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev)
        struct clk *clk;
 
        phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
-       if (!phy) {
-               dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n");
+       if (!phy)
                return -ENOMEM;
-       }
+
        phy->dev                = &pdev->dev;
 
        if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {