OSDN Git Service

net: ethernet: ave: Remove duplicate phy_resume() calls
authorKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Mon, 24 Oct 2022 07:23:14 +0000 (16:23 +0900)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Oct 2022 03:20:24 +0000 (20:20 -0700)
ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
need to call phy_resume() explicitly. Remove it.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Link: https://lore.kernel.org/r/20221024072314.24969-1-hayashi.kunihiko@socionext.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/socionext/sni_ave.c

index 1fa09b4..f7a44e0 100644 (file)
@@ -1760,12 +1760,6 @@ static int ave_resume(struct device *dev)
        wol.wolopts = priv->wolopts;
        __ave_ethtool_set_wol(ndev, &wol);
 
-       if (ndev->phydev) {
-               ret = phy_resume(ndev->phydev);
-               if (ret)
-                       return ret;
-       }
-
        if (netif_running(ndev)) {
                ret = ave_open(ndev);
                netif_device_attach(ndev);