OSDN Git Service

scsi: megaraid_sas: Remove unnecessary memset
authorWan Jiabing <wanjiabing@vivo.com>
Thu, 7 Apr 2022 07:24:42 +0000 (15:24 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 12 Apr 2022 01:55:12 +0000 (21:55 -0400)
instance->cmd_list is allocated by kcalloc(). The memory is already set to
zero. It is unnecessary to call memset again.

Link: https://lore.kernel.org/r/20220407072442.4137977-1-wanjiabing@vivo.com
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c

index 8bf72db..33f3226 100644 (file)
@@ -4466,8 +4466,6 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
                return -ENOMEM;
        }
 
-       memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd);
-
        for (i = 0; i < max_cmd; i++) {
                instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd),
                                                GFP_KERNEL);