OSDN Git Service

staging: comedi: dt3000: tidy up digital i/o subdevice init
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 8 Oct 2015 17:48:26 +0000 (10:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 05:59:26 +0000 (22:59 -0700)
Remove the unnecessary 'len_chanlist' initialization. This member is
only used by subdevices that support async commands.

For aesthetics, reorder the initialization a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt3000.c

index 2d293e6..5d1e4bb 100644 (file)
@@ -694,16 +694,15 @@ static int dt3000_auto_attach(struct comedi_device *dev,
                s->type         = COMEDI_SUBD_UNUSED;
        }
 
+       /* Digital I/O subdevice */
        s = &dev->subdevices[2];
-       /* dio subsystem */
        s->type         = COMEDI_SUBD_DIO;
        s->subdev_flags = SDF_READABLE | SDF_WRITABLE;
        s->n_chan       = 8;
-       s->insn_config  = dt3k_dio_insn_config;
-       s->insn_bits    = dt3k_dio_insn_bits;
        s->maxdata      = 1;
-       s->len_chanlist = 8;
        s->range_table  = &range_digital;
+       s->insn_config  = dt3k_dio_insn_config;
+       s->insn_bits    = dt3k_dio_insn_bits;
 
        s = &dev->subdevices[3];
        /* mem subsystem */