OSDN Git Service

target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features
authorPan Nengyuan <pannengyuan@huawei.com>
Mon, 31 Aug 2020 13:43:11 +0000 (09:43 -0400)
committerEduardo Habkost <ehabkost@redhat.com>
Wed, 2 Sep 2020 11:29:29 +0000 (07:29 -0400)
'err' forgot to free in x86_cpu_class_check_missing_features error path.
Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200831134315.1221-7-pannengyuan@huawei.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
target/i386/cpu.c

index ba4667b..49d8958 100644 (file)
@@ -4947,6 +4947,7 @@ static void x86_cpu_class_check_missing_features(X86CPUClass *xcc,
         new->value = g_strdup("type");
         *next = new;
         next = &new->next;
+        error_free(err);
     }
 
     x86_cpu_filter_features(xc, false);