OSDN Git Service

ASoC: SOF: Intel: hda-stream: report error on stream not opened
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 16 Jun 2022 21:53:40 +0000 (16:53 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 17 Jun 2022 09:46:37 +0000 (10:46 +0100)
We report -ENODEV but only use dev_dbg, this is
inconsistent. dev_err() makes sense here.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220616215351.135643-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-stream.c

index daeb64c..d3403b7 100644 (file)
@@ -271,7 +271,7 @@ int hda_dsp_stream_put(struct snd_sof_dev *sdev, int direction, int stream_tag)
                                        HDA_VS_INTEL_EM2_L1SEN, HDA_VS_INTEL_EM2_L1SEN);
 
        if (!found) {
-               dev_dbg(sdev->dev, "%s: stream_tag %d not opened!\n",
+               dev_err(sdev->dev, "%s: stream_tag %d not opened!\n",
                        __func__, stream_tag);
                return -ENODEV;
        }