OSDN Git Service

net/mlx5: Simplify eq list traversal
authorParav Pandit <parav@nvidia.com>
Thu, 16 Feb 2023 00:09:13 +0000 (16:09 -0800)
committerSaeed Mahameed <saeedm@nvidia.com>
Sat, 18 Feb 2023 09:01:33 +0000 (01:01 -0800)
EQ list is read only while finding the matching EQ.
Hence, avoid *_safe() version.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
drivers/net/ethernet/mellanox/mlx5/core/eq.c

index 66ec793..38b32e9 100644 (file)
@@ -960,11 +960,11 @@ static int vector2eqnirqn(struct mlx5_core_dev *dev, int vector, int *eqn,
                          unsigned int *irqn)
 {
        struct mlx5_eq_table *table = dev->priv.eq_table;
-       struct mlx5_eq_comp *eq, *n;
+       struct mlx5_eq_comp *eq;
        int err = -ENOENT;
        int i = 0;
 
-       list_for_each_entry_safe(eq, n, &table->comp_eqs_list, list) {
+       list_for_each_entry(eq, &table->comp_eqs_list, list) {
                if (i++ == vector) {
                        if (irqn)
                                *irqn = eq->core.irqn;
@@ -999,10 +999,10 @@ struct cpumask *
 mlx5_comp_irq_get_affinity_mask(struct mlx5_core_dev *dev, int vector)
 {
        struct mlx5_eq_table *table = dev->priv.eq_table;
-       struct mlx5_eq_comp *eq, *n;
+       struct mlx5_eq_comp *eq;
        int i = 0;
 
-       list_for_each_entry_safe(eq, n, &table->comp_eqs_list, list) {
+       list_for_each_entry(eq, &table->comp_eqs_list, list) {
                if (i++ == vector)
                        break;
        }