Cppcheck: Variable 'm_oldPackingInfo' is assigned in constructor body. Consider perfo...

--HG--
branch : stable

diff --git a/Src/Merge7zFormatMergePluginImpl.h b/Src/Merge7zFormatMergePluginImpl.h
index a55300b..c8f5a36 100644 (file)
--- a/Src/Merge7zFormatMergePluginImpl.h
+++ b/Src/Merge7zFormatMergePluginImpl.h
@@ -41,9 +41,8 @@ struct Merge7zFormatMergePluginImpl : public Merge7z::Format
 
 struct Merge7zFormatMergePluginScope
 {
-       Merge7zFormatMergePluginScope(const PackingInfo *infoUnpacker)
+       Merge7zFormatMergePluginScope(const PackingInfo *infoUnpacker) : m_oldPackingInfo(*Merge7zFormatMergePluginImpl::GetPackingInfo())
        {
-               m_oldPackingInfo = *Merge7zFormatMergePluginImpl::GetPackingInfo();
                Merge7zFormatMergePluginImpl::SetPackingInfo(infoUnpacker);
        }
        ~Merge7zFormatMergePluginScope()