OSDN Git Service

wifi: mt76: mt7915: add chip id condition in mt7915_check_eeprom()
authorShayne Chen <shayne.chen@mediatek.com>
Fri, 16 Dec 2022 04:05:31 +0000 (12:05 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 3 Feb 2023 13:47:16 +0000 (14:47 +0100)
When flash mode is enabled, and the eeprom data in the flash is not for
the current chipset, it'll still be checked valid, and the default
eeprom bin won't be loaded.
(e.g., mt7915 NIC inserted with mt7916 eeprom data in the flash.)

Fix this kind of case by adding chip id into consideration in
mt7915_check_eeprom().

Reported-by: Cheng-Ji Li <cheng-ji.li@mediatek.com>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/eeprom.c

index 24efa28..a796289 100644 (file)
@@ -33,11 +33,14 @@ static int mt7915_check_eeprom(struct mt7915_dev *dev)
        u8 *eeprom = dev->mt76.eeprom.data;
        u16 val = get_unaligned_le16(eeprom);
 
+#define CHECK_EEPROM_ERR(match)        (match ? 0 : -EINVAL)
        switch (val) {
        case 0x7915:
+               return CHECK_EEPROM_ERR(is_mt7915(&dev->mt76));
        case 0x7916:
+               return CHECK_EEPROM_ERR(is_mt7916(&dev->mt76));
        case 0x7986:
-               return 0;
+               return CHECK_EEPROM_ERR(is_mt7986(&dev->mt76));
        default:
                return -EINVAL;
        }