OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
16e8745
)
drm/i915/pmu: Keep a reference to module while active
author
Chris Wilson
<chris@chris-wilson.co.uk>
Thu, 30 Apr 2020 18:33:24 +0000
(19:33 +0100)
committer
Chris Wilson
<chris@chris-wilson.co.uk>
Fri, 1 May 2020 08:24:34 +0000
(09:24 +0100)
While a perf event is open, keep a reference to the module so we don't
remove the driver internals mid-sampling.
Testcase: igt/perf_pmu/module-unload
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20200430183324.23984-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_pmu.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/i915/i915_pmu.c
b/drivers/gpu/drm/i915/i915_pmu.c
index
83c6a8c
..
e991a70
100644
(file)
--- a/
drivers/gpu/drm/i915/i915_pmu.c
+++ b/
drivers/gpu/drm/i915/i915_pmu.c
@@
-442,6
+442,7
@@
static u64 count_interrupts(struct drm_i915_private *i915)
static void i915_pmu_event_destroy(struct perf_event *event)
{
WARN_ON(event->parent);
+ module_put(THIS_MODULE);
}
static int
@@
-533,8
+534,10
@@
static int i915_pmu_event_init(struct perf_event *event)
if (ret)
return ret;
- if (!event->parent)
+ if (!event->parent) {
+ __module_get(THIS_MODULE);
event->destroy = i915_pmu_event_destroy;
+ }
return 0;
}