OSDN Git Service

block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec
authorChristoph Hellwig <hch@lst.de>
Tue, 24 Jul 2018 12:04:13 +0000 (14:04 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 24 Jul 2018 20:39:28 +0000 (14:39 -0600)
So don't bother handling it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c

index 504b422..07d3ffd 100644 (file)
@@ -1636,10 +1636,8 @@ void bio_set_pages_dirty(struct bio *bio)
        int i;
 
        bio_for_each_segment_all(bvec, bio, i) {
-               struct page *page = bvec->bv_page;
-
-               if (page && !PageCompound(page))
-                       set_page_dirty_lock(page);
+               if (!PageCompound(bvec->bv_page))
+                       set_page_dirty_lock(bvec->bv_page);
        }
 }
 EXPORT_SYMBOL_GPL(bio_set_pages_dirty);