OSDN Git Service

drm/i915: remove the TODO in pin_and_fence_fb_obj
authorMatthew Auld <matthew.auld@intel.com>
Tue, 4 Oct 2022 13:19:12 +0000 (14:19 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Wed, 5 Oct 2022 08:01:49 +0000 (09:01 +0100)
The copy is async (if there even is one), but when later updating the
GGTT we always sync against the binding, which will in turn sync against
any moves.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Jianshui Yu <jianshui.yu@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221004131916.233474-1-matthew.auld@intel.com
drivers/gpu/drm/i915/display/intel_fb_pin.c

index c86e5d4..0cd9e8c 100644 (file)
@@ -141,7 +141,6 @@ retry:
                ret = i915_gem_object_attach_phys(obj, alignment);
        else if (!ret && HAS_LMEM(dev_priv))
                ret = i915_gem_object_migrate(obj, &ww, INTEL_REGION_LMEM_0);
-       /* TODO: Do we need to sync when migration becomes async? */
        if (!ret)
                ret = i915_gem_object_pin_pages(obj);
        if (ret)