de-duplicate code a bit

diff --git a/src/plugins/coreplugin/editormanager/openeditorsmodel.cpp b/src/plugins/coreplugin/editormanager/openeditorsmodel.cpp
index dbffb71..d205e3d 100644 (file)
--- a/src/plugins/coreplugin/editormanager/openeditorsmodel.cpp
+++ b/src/plugins/coreplugin/editormanager/openeditorsmodel.cpp
@@ -196,18 +196,16 @@ int OpenEditorsModel::findFileName(const QString &filename) const
 void OpenEditorsModel::removeEditor(IEditor *editor)
 {
     d->m_duplicateEditors.removeAll(editor);
-    int idx = findEditor(editor);
-    if (idx < 0)
-        return;
-    beginRemoveRows(QModelIndex(), idx, idx);
-    d->m_editors.removeAt(idx);
-    endRemoveRows();
-    disconnect(editor, SIGNAL(changed()), this, SLOT(itemChanged()));
+    removeEditor(findEditor(editor));
 }
 
 void OpenEditorsModel::removeEditor(const QModelIndex &index)
 {
-    int idx = index.row();
+    removeEditor(index.row());
+}
+
+void OpenEditorsModel::removeEditor(int idx)
+{
     if (idx < 0)
         return;
     IEditor *editor= d->m_editors.at(idx).editor;

diff --git a/src/plugins/coreplugin/editormanager/openeditorsmodel.h b/src/plugins/coreplugin/editormanager/openeditorsmodel.h
index 62e0928..ab9b14b 100644 (file)
--- a/src/plugins/coreplugin/editormanager/openeditorsmodel.h
+++ b/src/plugins/coreplugin/editormanager/openeditorsmodel.h
@@ -103,6 +103,7 @@ private:
     void addEntry(const Entry &entry);
     int findEditor(IEditor *editor) const;
     int findFileName(const QString &filename) const;
+    void removeEditor(int idx);
 
     QScopedPointer<OpenEditorsModelPrivate> d;
 };