OSDN Git Service

drm/msm: Removed unused struct_mutex_task
authorJordan Crouse <jcrouse@codeaurora.org>
Fri, 20 Oct 2017 17:07:02 +0000 (11:07 -0600)
committerRob Clark <robdclark@gmail.com>
Sat, 28 Oct 2017 15:01:39 +0000 (11:01 -0400)
Recent changes to locking have rendered struct_mutex_task
unused.

Unused since 0e08270a1f01.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/msm_drv.h
drivers/gpu/drm/msm/msm_gem_submit.c

index 9853e3e..c46dc12 100644 (file)
@@ -154,12 +154,6 @@ struct msm_drm_private {
        struct shrinker shrinker;
 
        struct msm_vblank_ctrl vblank_ctrl;
-
-       /* task holding struct_mutex.. currently only used in submit path
-        * to detect and reject faults from copy_from_user() for submit
-        * ioctl.
-        */
-       struct task_struct *struct_mutex_task;
 };
 
 struct msm_format {
index d3551aa..6986868 100644 (file)
@@ -463,7 +463,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
                        goto out_unlock;
                }
        }
-       priv->struct_mutex_task = current;
 
        submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds);
        if (!submit) {
@@ -581,7 +580,6 @@ out:
 out_unlock:
        if (ret && (out_fence_fd >= 0))
                put_unused_fd(out_fence_fd);
-       priv->struct_mutex_task = NULL;
        mutex_unlock(&dev->struct_mutex);
        return ret;
 }