OSDN Git Service

mptcp: implement support for user-space disconnect
authorPaolo Abeni <pabeni@redhat.com>
Fri, 7 Jan 2022 00:20:18 +0000 (16:20 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Jan 2022 11:27:07 +0000 (11:27 +0000)
Handle explicitly AF_UNSPEC in mptcp_stream_connnect() to
allow user-space to disconnect established MPTCP connections

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.c

index 628cd60..667e153 100644 (file)
@@ -3404,9 +3404,20 @@ static int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr,
        struct mptcp_sock *msk = mptcp_sk(sock->sk);
        struct mptcp_subflow_context *subflow;
        struct socket *ssock;
-       int err;
+       int err = -EINVAL;
 
        lock_sock(sock->sk);
+       if (uaddr) {
+               if (addr_len < sizeof(uaddr->sa_family))
+                       goto unlock;
+
+               if (uaddr->sa_family == AF_UNSPEC) {
+                       err = mptcp_disconnect(sock->sk, flags);
+                       sock->state = err ? SS_DISCONNECTING : SS_UNCONNECTED;
+                       goto unlock;
+               }
+       }
+
        if (sock->state != SS_UNCONNECTED && msk->subflow) {
                /* pending connection or invalid state, let existing subflow
                 * cope with that
@@ -3416,10 +3427,8 @@ static int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr,
        }
 
        ssock = __mptcp_nmpc_socket(msk);
-       if (!ssock) {
-               err = -EINVAL;
+       if (!ssock)
                goto unlock;
-       }
 
        mptcp_token_destroy(msk);
        inet_sk_state_store(sock->sk, TCP_SYN_SENT);