OSDN Git Service

crypto: marvell/cesa - remove redundant backlog checks on EBUSY
authorGilad Ben-Yossef <gilad@benyossef.com>
Wed, 18 Oct 2017 07:00:37 +0000 (08:00 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 3 Nov 2017 14:11:18 +0000 (22:11 +0800)
Now that -EBUSY return code only indicates backlog queueing
we can safely remove the now redundant check for the
CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/cesa.c
drivers/crypto/marvell/cesa.h

index 03604df..2c0d6bd 100644 (file)
@@ -177,8 +177,7 @@ int mv_cesa_queue_req(struct crypto_async_request *req,
        spin_lock_bh(&engine->lock);
        ret = crypto_enqueue_request(&engine->queue, req);
        if ((mv_cesa_req_get_type(creq) == CESA_DMA_REQ) &&
-           (ret == -EINPROGRESS ||
-           (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG)))
+           (ret == -EINPROGRESS || ret == -EBUSY))
                mv_cesa_tdma_chain(engine, creq);
        spin_unlock_bh(&engine->lock);
 
index acf8194..18a3274 100644 (file)
@@ -764,7 +764,7 @@ static inline int mv_cesa_req_needs_cleanup(struct crypto_async_request *req,
         * the backlog and will be processed later. There's no need to
         * clean it up.
         */
-       if (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG)
+       if (ret == -EBUSY)
                return false;
 
        /* Request wasn't queued, we need to clean it up */