OSDN Git Service

perf probe: Remove redundant cleanup of params.filter
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Tue, 5 May 2015 02:29:52 +0000 (11:29 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 5 May 2015 21:13:05 +0000 (18:13 -0300)
Since params.filter will be released in cleanup_params, we don't need to
clear it in each command.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20150505022952.23399.58072.stgit@localhost.localdomain
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-probe.c

index 5a0e8f1..08c9481 100644 (file)
@@ -477,8 +477,6 @@ __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
                        usage_with_options(probe_usage, options);
                }
                ret = show_perf_probe_events(params.filter);
-               strfilter__delete(params.filter);
-               params.filter = NULL;
                if (ret < 0)
                        pr_err_with_code("  Error: Failed to show event list.", ret);
                return ret;
@@ -486,8 +484,6 @@ __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
        if (params.show_funcs) {
                ret = show_available_funcs(params.target, params.filter,
                                        params.uprobes);
-               strfilter__delete(params.filter);
-               params.filter = NULL;
                if (ret < 0)
                        pr_err_with_code("  Error: Failed to show functions.", ret);
                return ret;
@@ -511,8 +507,6 @@ __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
                                          params.target,
                                          params.filter,
                                          params.show_ext_vars);
-               strfilter__delete(params.filter);
-               params.filter = NULL;
                if (ret < 0)
                        pr_err_with_code("  Error: Failed to show vars.", ret);
                return ret;