OSDN Git Service

net/mlx5e: IPoIB, Fix RX checksum statistics update
authorFeras Daoud <ferasda@mellanox.com>
Mon, 14 Jan 2019 15:34:28 +0000 (17:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:31 +0000 (14:50 +0100)
[ Upstream commit 3d6f3cdf9bfe92c430674308db0f1c8655f2c11d ]

Update the RX checksum only if the feature is enabled.

Fixes: 9d6bd752c63c ("net/mlx5e: IPoIB, RX handler")
Signed-off-by: Feras Daoud <ferasda@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

index 9cbc417..044687a 100644 (file)
@@ -1364,8 +1364,14 @@ static inline void mlx5i_complete_rx_cqe(struct mlx5e_rq *rq,
 
        skb->protocol = *((__be16 *)(skb->data));
 
-       skb->ip_summed = CHECKSUM_COMPLETE;
-       skb->csum = csum_unfold((__force __sum16)cqe->check_sum);
+       if (netdev->features & NETIF_F_RXCSUM) {
+               skb->ip_summed = CHECKSUM_COMPLETE;
+               skb->csum = csum_unfold((__force __sum16)cqe->check_sum);
+               stats->csum_complete++;
+       } else {
+               skb->ip_summed = CHECKSUM_NONE;
+               stats->csum_none++;
+       }
 
        if (unlikely(mlx5e_rx_hw_stamp(tstamp)))
                skb_hwtstamps(skb)->hwtstamp =
@@ -1384,7 +1390,6 @@ static inline void mlx5i_complete_rx_cqe(struct mlx5e_rq *rq,
 
        skb->dev = netdev;
 
-       stats->csum_complete++;
        stats->packets++;
        stats->bytes += cqe_bcnt;
 }