OSDN Git Service

media: rkvdec:Remove redundant memset
authorZhang Zekun <zhangzekun11@huawei.com>
Fri, 17 Jun 2022 09:39:25 +0000 (10:39 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 27 Jun 2022 08:13:03 +0000 (09:13 +0100)
As dma_alloc_coherent() will return a zeroed buffer, we
don't need to memset the returned buffer.
priv_tbl = dma_alloc_coherent() and count_tbl = dma_alloc_coherent()
should be enough.

-see commit 750afb08ca71 ("cross-tree: phase out dma_zalloc_coherent()")

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/rkvdec/rkvdec-vp9.c

index 311a126..c2f42e7 100644 (file)
@@ -1015,7 +1015,6 @@ static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)
 
        vp9_ctx->priv_tbl.size = sizeof(*priv_tbl);
        vp9_ctx->priv_tbl.cpu = priv_tbl;
-       memset(priv_tbl, 0, sizeof(*priv_tbl));
 
        count_tbl = dma_alloc_coherent(rkvdec->dev, RKVDEC_VP9_COUNT_SIZE,
                                       &vp9_ctx->count_tbl.dma, GFP_KERNEL);
@@ -1026,7 +1025,6 @@ static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)
 
        vp9_ctx->count_tbl.size = RKVDEC_VP9_COUNT_SIZE;
        vp9_ctx->count_tbl.cpu = count_tbl;
-       memset(count_tbl, 0, sizeof(*count_tbl));
        rkvdec_init_v4l2_vp9_count_tbl(ctx);
 
        return 0;