OSDN Git Service

drm/gma500: Remove null check before kfree
authorHimanshu Jha <himanshujha199640@gmail.com>
Wed, 30 Aug 2017 13:25:56 +0000 (18:55 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 31 Aug 2017 07:24:15 +0000 (09:24 +0200)
kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1504099556-3887-1-git-send-email-himanshujha199640@gmail.com
drivers/gpu/drm/gma500/cdv_intel_dp.c

index c52f9ad..a4bb89b 100644 (file)
@@ -1901,10 +1901,8 @@ cdv_intel_dp_destroy(struct drm_connector *connector)
 
        if (is_edp(gma_encoder)) {
        /*      cdv_intel_panel_destroy_backlight(connector->dev); */
-               if (intel_dp->panel_fixed_mode) {
-                       kfree(intel_dp->panel_fixed_mode);
-                       intel_dp->panel_fixed_mode = NULL;
-               }
+               kfree(intel_dp->panel_fixed_mode);
+               intel_dp->panel_fixed_mode = NULL;
        }
        i2c_del_adapter(&intel_dp->adapter);
        drm_connector_unregister(connector);