OSDN Git Service

mailbox: bcm-pdc: Remove redundant error printing in pdc_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 11:56:54 +0000 (19:56 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Sat, 26 Jun 2021 16:37:50 +0000 (11:37 -0500)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/bcm-pdc-mailbox.c

index 5b37598..8d3a4c1 100644 (file)
@@ -1577,7 +1577,6 @@ static int pdc_probe(struct platform_device *pdev)
        pdcs->pdc_reg_vbase = devm_ioremap_resource(&pdev->dev, pdc_regs);
        if (IS_ERR(pdcs->pdc_reg_vbase)) {
                err = PTR_ERR(pdcs->pdc_reg_vbase);
-               dev_err(&pdev->dev, "Failed to map registers: %d\n", err);
                goto cleanup_ring_pool;
        }