OSDN Git Service

i2c: rcar: use core to detect 'no zero length' quirk
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 23 Jul 2018 20:26:14 +0000 (22:26 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Sat, 4 Aug 2018 21:25:07 +0000 (23:25 +0200)
And don't reimplement in the driver.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-rcar.c

index 2688520..791a4aa 100644 (file)
@@ -796,14 +796,8 @@ static int rcar_i2c_master_xfer(struct i2c_adapter *adap,
        if (ret < 0)
                goto out;
 
-       for (i = 0; i < num; i++) {
-               /* This HW can't send STOP after address phase */
-               if (msgs[i].len == 0) {
-                       ret = -EOPNOTSUPP;
-                       goto out;
-               }
+       for (i = 0; i < num; i++)
                rcar_i2c_request_dma(priv, msgs + i);
-       }
 
        /* init first message */
        priv->msg = msgs;
@@ -890,6 +884,10 @@ static const struct i2c_algorithm rcar_i2c_algo = {
        .unreg_slave    = rcar_unreg_slave,
 };
 
+static const struct i2c_adapter_quirks rcar_i2c_quirks = {
+       .flags = I2C_AQ_NO_ZERO_LEN,
+};
+
 static const struct of_device_id rcar_i2c_dt_ids[] = {
        { .compatible = "renesas,i2c-r8a7778", .data = (void *)I2C_RCAR_GEN1 },
        { .compatible = "renesas,i2c-r8a7779", .data = (void *)I2C_RCAR_GEN1 },
@@ -943,6 +941,7 @@ static int rcar_i2c_probe(struct platform_device *pdev)
        adap->dev.parent = dev;
        adap->dev.of_node = dev->of_node;
        adap->bus_recovery_info = &rcar_i2c_bri;
+       adap->quirks = &rcar_i2c_quirks;
        i2c_set_adapdata(adap, priv);
        strlcpy(adap->name, pdev->name, sizeof(adap->name));