OSDN Git Service

spi: xtensa-xtfpga: Use devm_platform_ioremap_resource() in xtfpga_spi_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 21 Sep 2019 13:35:08 +0000 (15:35 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 1 Oct 2019 11:35:18 +0000 (12:35 +0100)
Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/178bb78e-714f-645f-d819-5732870c4272@web.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-xtensa-xtfpga.c

index 86516eb..fc2b5eb 100644 (file)
@@ -80,7 +80,6 @@ static void xtfpga_spi_chipselect(struct spi_device *spi, int is_on)
 static int xtfpga_spi_probe(struct platform_device *pdev)
 {
        struct xtfpga_spi *xspi;
-       struct resource *mem;
        int ret;
        struct spi_master *master;
 
@@ -97,14 +96,7 @@ static int xtfpga_spi_probe(struct platform_device *pdev)
        xspi->bitbang.master = master;
        xspi->bitbang.chipselect = xtfpga_spi_chipselect;
        xspi->bitbang.txrx_word[SPI_MODE_0] = xtfpga_spi_txrx_word;
-
-       mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!mem) {
-               dev_err(&pdev->dev, "No memory resource\n");
-               ret = -ENODEV;
-               goto err;
-       }
-       xspi->regs = devm_ioremap_resource(&pdev->dev, mem);
+       xspi->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(xspi->regs)) {
                ret = PTR_ERR(xspi->regs);
                goto err;