OSDN Git Service

drm/udl: Remove unused statistics counters
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 6 Dec 2019 08:59:48 +0000 (09:59 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 6 Dec 2019 12:51:16 +0000 (13:51 +0100)
None of the udl driver's statistics counters is used anywhere. Remove
them.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191206085954.9697-2-tzimmermann@suse.de
drivers/gpu/drm/udl/udl_drv.h
drivers/gpu/drm/udl/udl_fb.c

index 66cbe04..4242640 100644 (file)
@@ -66,10 +66,6 @@ struct udl_device {
 
        char mode_buf[1024];
        uint32_t mode_buf_len;
-       atomic_t bytes_rendered; /* raw pixel-bytes driver asked to render */
-       atomic_t bytes_identical; /* saved effort with backbuffer comparison */
-       atomic_t bytes_sent; /* to usb, after compression including overhead */
-       atomic_t cpu_kcycles_used; /* transpired during pixel processing */
 };
 
 #define to_udl(x) container_of(x, struct udl_device, drm)
index c1996ac..bc03377 100644 (file)
@@ -68,7 +68,6 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
        struct udl_device *udl = to_udl(dev);
        int i, ret;
        char *cmd;
-       cycles_t start_cycles, end_cycles;
        int bytes_sent = 0;
        int bytes_identical = 0;
        struct urb *urb;
@@ -105,8 +104,6 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
                goto err_drm_gem_shmem_vunmap;
        }
 
-       start_cycles = get_cycles();
-
        urb = udl_get_urb(dev);
        if (!urb)
                goto out;
@@ -120,7 +117,7 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
                                     &cmd, byte_offset, dev_byte_offset,
                                     width << log_bpp,
                                     &bytes_identical, &bytes_sent))
-                       goto error;
+                       goto out;
        }
 
        if (cmd > (char *) urb->transfer_buffer) {
@@ -134,15 +131,6 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
        } else
                udl_urb_completion(urb);
 
-error:
-       atomic_add(bytes_sent, &udl->bytes_sent);
-       atomic_add(bytes_identical, &udl->bytes_identical);
-       atomic_add((width * height) << log_bpp, &udl->bytes_rendered);
-       end_cycles = get_cycles();
-       atomic_add(((unsigned int) ((end_cycles - start_cycles)
-                   >> 10)), /* Kcycles */
-                  &udl->cpu_kcycles_used);
-
 out:
        drm_gem_shmem_vunmap(fb->obj[0], vaddr);