OSDN Git Service

nvme-multipath: fix logic for non-optimized paths
authorMartin Wilck <mwilck@suse.com>
Mon, 27 Jul 2020 16:08:02 +0000 (18:08 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 29 Jul 2020 05:45:22 +0000 (07:45 +0200)
Handle the special case where we have exactly one optimized path,
which we should keep using in this case.

Fixes: 75c10e732724 ("nvme-multipath: round-robin I/O policy")
Signed off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/multipath.c

index 900b35d..93c70e1 100644 (file)
@@ -255,6 +255,12 @@ static struct nvme_ns *nvme_round_robin_path(struct nvme_ns_head *head,
                        fallback = ns;
        }
 
+       /* No optimized path found, re-check the current path */
+       if (!nvme_path_is_disabled(old) &&
+           old->ana_state == NVME_ANA_OPTIMIZED) {
+               found = old;
+               goto out;
+       }
        if (!fallback)
                return NULL;
        found = fallback;