OSDN Git Service

scsi: BusLogic: Remove conversion to bool in blogic_inquiry()
authorJason Yan <yanaijie@huawei.com>
Tue, 21 Apr 2020 03:41:20 +0000 (11:41 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 24 Apr 2020 22:21:14 +0000 (18:21 -0400)
The '!=' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
needed here

Link: https://lore.kernel.org/r/20200421034120.28433-1-yanaijie@huawei.com
Acked-by: Khalid Aziz <khalid@gonehiking.org>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/BusLogic.c

index b5b3154..bb49d83 100644 (file)
@@ -2237,7 +2237,7 @@ static bool __init blogic_inquiry(struct blogic_adapter *adapter)
                                        "INQUIRE INSTALLED DEVICES ID 0 TO 7");
                for (tgt_id = 0; tgt_id < 8; tgt_id++)
                        adapter->tgt_flags[tgt_id].tgt_exists =
-                               (installed_devs0to7[tgt_id] != 0 ? true : false);
+                               installed_devs0to7[tgt_id] != 0;
        }
        /*
           Issue the Inquire Setup Information command.